FIX cupy.is_in_gpu for numpy >= 2.0 - #99
Merged
Merged
Conversation
kroq-gar78
marked this pull request as ready for review
April 12, 2026 22:16
kroq-gar78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests in
himalaya/kernel_ridge/tests/test_force_cpu.pywere failing for the cupy backend whenforce_cpu=True.NumPy 2.0 added compliance with the Array API, which means a
.deviceproperty for allndarrays that's always equal to'cpu'. Previously, himalaya assumed that the property did not exist when checking the device. I tested this PR locally, and it works for both NumPy >=2.0 and 1.26.4 (the last pre-2.0 release).